Double escape defines in gnuarmeclipse export

[theotherjimmy]

Fixes a bug where quoting gets stripped by the shell used in the makefile
and another bug where the lack of escaping would cause parser errors in
eclipse.

Resolves #4622

[JojoS62]

#4637

[JojoS62]

this fix works, but it leaves backslashes that can be removed?

[theotherjimmy]

Nope. Those are required to allow it to build

…

On Jun 26, 2017 12:19 PM, "JojoS" ***@***.***> wrote: this fix works, but it leaves backslashes that can be removed? [image: grafik] <https://user-images.githubusercontent.com/6775562/27551586-44ffb636-5aa4-11e7-9cb2-cb32cb30c614.png> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#4636 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAp1Yd1I2wIOjcGthydo9Yh_fhGq218dks5sH-gSgaJpZM4OFlav> .

[theotherjimmy]

Oh joy. A travis bug on master.

[theotherjimmy]

@JojoS62 Let me explain why those extra escapes are required. First, we are using this define in place of an include file. We cannot quote the argument to #include as it will not expand the macro in that instance. Instead, we are left with adding the quotes to the macro. Next, we have to pass this quoted value with the quotes to the compiler on the command line. This reqires a

str.replace("\"", "\\\"")

Which will prevent the shell from expanding the quotes itself. Now we need to pass that value, backslashes, quotes and all, to eclipse. That is done by escaping the value for HTML, a function built into Jinja2.

TL;DR: backslashes are needed to build correctly.

[JojoS62]

thanks, and you're right, without backslashes the compiler complains.

[JojoS62]

just one more thing for my curiosity:
I've checked it also in SW4STM32 and there the leading backslashes are not necessary. The reason should be the different ways how the different build systems work.
As a side effect, the eclipse C++ indexer gets confused by the backslahes in the macro value. It compiles, but wouldn't it be a cleaner solution when the gnuarmeclipse plugin modifies the symbol value as needed? @ilg : what do you think?

[theotherjimmy]

@JojoS62 I agree that It would be cleaner to not escape the macro for the makefile under eclipse.

[theotherjimmy]

/morph export-build

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 75

Exporter Build failed!

[theotherjimmy]

sigh these errors are probably on master...

[theotherjimmy]

/morph export-build

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 76

Exporter Build failed!

[studavekar]

/morph export-build

[mbed-bot]

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 78

Exporter Build failed!

[studavekar]

/morph export-build

[mbed-bot]

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph export-build

Output

mbed Build Number: 82

All exports and builds passed!

[theotherjimmy]

Wohooo!

LGTM!!