-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update and mute debug messages of REALTEK_TRL8195AM #4667
Conversation
Thanks, it removes most of the messages
Any chance we can get rid of these as well:
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
@Archcady Can you comment on #4667 (comment) ? If its possible to completely remove debug lines? It shall not block this PR, but would be nice to have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks, it doesn't print any debug info now. Any chance we could do something like that:
RTWInterface::RTWInterface(bool debug=false)
and set the GlobalDebugEnable
accordingly.
@bulislaw Good idea, I submit another commit, and many thanks. |
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
No description provided.