Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent mbed-trace dummy defines and original function declarations #4706

Merged
merged 1 commit into from
Jul 24, 2017

Conversation

yogpan01
Copy link
Contributor

@yogpan01 yogpan01 commented Jul 5, 2017

Description

This commit fixes PelionIoT/mbed-trace#70

Status

READY

Migrations

NO

Related PRs

List related PRs against other branches:
PelionIoT/mbed-trace#71

@yogpan01
Copy link
Contributor Author

yogpan01 commented Jul 5, 2017

@0xc0170 @adbridge Please take this in for next mbed OS release candidate.
@shelib01 @TaniaMirzin @jupe FYI

@AnotherButler
Copy link
Contributor

@yogpan01 Thanks for the PR.

Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. To match this format, please change your subject line to the imperative mood by changing "Fixes" to "Fix", and shorten your subject line to 50 characters. Thank you. :)

@theotherjimmy
Copy link
Contributor

@yogpan01 Could you reword your commit messages? If you want this to get into 5.5.3, it needs to be ready for merge by Thursday.

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 11, 2017

bump

@yogpan01
Copy link
Contributor Author

Ok, I will update PR now.

@yogpan01 yogpan01 changed the title Fixes inconsistent mbed-trace dummy defines and original function declarations Fix inconsistent mbed-trace dummy defines and original function declarations Jul 12, 2017
@yogpan01
Copy link
Contributor Author

@adbridge @0xc0170 Is this better now ? Can it make into next release candidate ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 17, 2017

/morph test-nightly

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 17, 2017

Can it make into next release candidate ?

The is already 5.5.3 as PR, should be released tomorrow, so this will go into the next one?

@yogpan01
Copy link
Contributor Author

@0xc0170 That's fine, Just wanted to make sure that it will eventually be merged into some release :)

@mbed-bot
Copy link

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 822

All builds and test passed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mbed-trace dummies defines and original functions declaration are different
6 participants