-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent mbed-trace dummy defines and original function declarations #4706
Conversation
@0xc0170 @adbridge Please take this in for next mbed OS release candidate. |
@yogpan01 Thanks for the PR. Also, we recommend our contributors follow Chris Beam’s seven rules of great commit messages to keep the commit history clear. To match this format, please change your subject line to the imperative mood by changing "Fixes" to "Fix", and shorten your subject line to 50 characters. Thank you. :) |
@yogpan01 Could you reword your commit messages? If you want this to get into 5.5.3, it needs to be ready for merge by Thursday. |
bump |
Ok, I will update PR now. |
/morph test-nightly |
The is already 5.5.3 as PR, should be released tomorrow, so this will go into the next one? |
@0xc0170 That's fine, Just wanted to make sure that it will eventually be merged into some release :) |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Description
This commit fixes PelionIoT/mbed-trace#70
Status
READY
Migrations
NO
Related PRs
List related PRs against other branches:
PelionIoT/mbed-trace#71