[fix] raw: fix channel layout #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Dukhovnikov <[email protected]>
lgritz
reviewed
Nov 6, 2024
src/raw.imageio/rawinput.cpp
Outdated
| case 0x49494949: return "GBGR"; | ||
| case 0x94949494: return "RGBG"; | ||
| default: break; | ||
| char result[5] = { 0 }; |
There was a problem hiding this comment.
I don't actually know... does this for sure fill the whole array with 0's? Is that part of the C++ standard, and not relying on any particular compiler?
lgritz
reviewed
Nov 6, 2024
Signed-off-by: Anton Dukhovnikov <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 10, 2024
The function libraw_filter_to_str() converts the `imgdata.idata.filters` field to human readable form, by mapping a few hardcoded values. I found the issue by converting images with disabled demosaicing, which writes the Bayer pattern into the ImageBuf metadata. The Panasonic GX9 didn't have any pattern recognised; The Canon R5 was incorrectly recognised as GMCY. The `imgdata.idata.filters` actually contains a sequence of 2-bit values, where each represents an index in a 4-character long string `imgdata.idata.cdesc`. I have modified the code to extract the channels from `imgdata.idata.cdesc` as expected. I have also disabled the normalisation code, which I believe was incorrect, and never executed due to the issue above. The current tests pass, however, I'll start a discussion on the piece of code I have concerns with. --------- Signed-off-by: Anton Dukhovnikov <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 10, 2024
The function libraw_filter_to_str() converts the `imgdata.idata.filters` field to human readable form, by mapping a few hardcoded values. I found the issue by converting images with disabled demosaicing, which writes the Bayer pattern into the ImageBuf metadata. The Panasonic GX9 didn't have any pattern recognised; The Canon R5 was incorrectly recognised as GMCY. The `imgdata.idata.filters` actually contains a sequence of 2-bit values, where each represents an index in a 4-character long string `imgdata.idata.cdesc`. I have modified the code to extract the channels from `imgdata.idata.cdesc` as expected. I have also disabled the normalisation code, which I believe was incorrect, and never executed due to the issue above. The current tests pass, however, I'll start a discussion on the piece of code I have concerns with. --------- Signed-off-by: Anton Dukhovnikov <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 13, 2024
The function libraw_filter_to_str() converts the `imgdata.idata.filters` field to human readable form, by mapping a few hardcoded values. I found the issue by converting images with disabled demosaicing, which writes the Bayer pattern into the ImageBuf metadata. The Panasonic GX9 didn't have any pattern recognised; The Canon R5 was incorrectly recognised as GMCY. The `imgdata.idata.filters` actually contains a sequence of 2-bit values, where each represents an index in a 4-character long string `imgdata.idata.cdesc`. I have modified the code to extract the channels from `imgdata.idata.cdesc` as expected. I have also disabled the normalisation code, which I believe was incorrect, and never executed due to the issue above. The current tests pass, however, I'll start a discussion on the piece of code I have concerns with. --------- Signed-off-by: Anton Dukhovnikov <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 21, 2024
The function libraw_filter_to_str() converts the `imgdata.idata.filters` field to human readable form, by mapping a few hardcoded values. I found the issue by converting images with disabled demosaicing, which writes the Bayer pattern into the ImageBuf metadata. The Panasonic GX9 didn't have any pattern recognised; The Canon R5 was incorrectly recognised as GMCY. The `imgdata.idata.filters` actually contains a sequence of 2-bit values, where each represents an index in a 4-character long string `imgdata.idata.cdesc`. I have modified the code to extract the channels from `imgdata.idata.cdesc` as expected. I have also disabled the normalisation code, which I believe was incorrect, and never executed due to the issue above. The current tests pass, however, I'll start a discussion on the piece of code I have concerns with. --------- Signed-off-by: Anton Dukhovnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function libraw_filter_to_str() converts the
imgdata.idata.filtersfield to human readable form, by mapping a few hardcoded values. I found the issue by converting images with disabled demosaicing, which writes the Bayer pattern into the ImageBuf metadata. The Panasonic GX9 didn't have any pattern recognised; The Canon R5 was incorrectly recognised as GMCY.The
imgdata.idata.filtersactually contains a sequence of 2-bit values, where each represents an index in a 4-character long stringimgdata.idata.cdesc. I have modified the code to extract the channels fromimgdata.idata.cdescas expected.I have also disabled the normalisation code, which I believe was incorrect, and never executed due to the issue above.
Tests
The current tests pass, however, I'll start a discussion on the piece of code I have concerns with.
Checklist:
need to update the documentation, for example if this is a bug fix that
doesn't change the API.)
(adding new test cases if necessary).
corresponding Python bindings (and if altering ImageBufAlgo functions, also
exposed the new functionality as oiiotool options).
already run clang-format before submitting, I definitely will look at the CI
test that runs clang-format and fix anything that it highlights as being
nonconforming.