Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Dependency default install #250

Merged
merged 4 commits into from
Jan 28, 2025
Merged

[Bug] Dependency default install #250

merged 4 commits into from
Jan 28, 2025

Conversation

bboynton97
Copy link
Contributor

@bboynton97 bboynton97 commented Jan 28, 2025 •
edited
Loading

A couple miscellaneous changes bundled into this

@bboynton97 bboynton97 requested a review from tcdent January 28, 2025 22:50
@codecov Codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agentstack/packaging.py 37.50% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

tcdent
tcdent approved these changes Jan 28, 2025
View reviewed changes
Copy link
Collaborator

@tcdent tcdent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saving n00bs from dependency hell since '24.

@bboynton97 bboynton97 merged commit 0d8a133 into main Jan 28, 2025
10 of 11 checks passed
@bboynton97 bboynton97 deleted the dependency-default-install branch January 28, 2025 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcdent tcdent tcdent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bboynton97 @tcdent