Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export ERTP types and normalize enum pattern #10263

Merged
merged 5 commits into from
Oct 15, 2024
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 11, 2024

refs: #4560

Description

Exports ERTP types from the package entrypoint.

Establishes a pattern for constant enums so the type name matches.

Review by commit

Security Considerations

none

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

Upgrade Considerations

@turadg turadg requested a review from a team as a code owner October 11, 2024 18:42
Copy link

cloudflare-workers-and-pages bot commented Oct 11, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0fa8c9f
Status: ✅  Deploy successful!
Preview URL: https://318ef72c.agoric-sdk.pages.dev
Branch Preview URL: https://ta-export-ertp-types.agoric-sdk.pages.dev

View logs

@turadg turadg changed the title export ERTP types export ERTP types and normalize enum pattern Oct 11, 2024
@turadg turadg added the automerge:rebase Automatically rebase updates, then merge label Oct 11, 2024
@turadg turadg force-pushed the ta/export-ERTP-types branch from e7c24be to f2faed3 Compare October 15, 2024 16:34
@turadg turadg force-pushed the ta/export-ERTP-types branch from f2faed3 to 0fa8c9f Compare October 15, 2024 17:22
@turadg turadg added the bypass:integration Prevent integration tests from running on PR label Oct 15, 2024
@mergify mergify bot merged commit dd37e03 into master Oct 15, 2024
78 of 84 checks passed
@mergify mergify bot deleted the ta/export-ERTP-types branch October 15, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants