getRUN contract, bootstrap integration (WIP) #4731
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- test: first steps toward borrowing RUN against BLD - test: prepare real attestation - docs: types for FP utilities - feat: terms are controlled by governance - fix: prevent forged attestation - test: forging an attestion should fail
- replace getInvitation with makeLoanInvitation
patterned after vault.js
- HIGH_FEE, LONG_EXP
- return uiNotifier, invitationMakers, vault
- factor out makeLineOfCreditKit
- add close OfferHandler
- track debtAmount, vaultState
- keep attestation in vaultSeat
- stub adjustBalances
- factor out makeCreditPolicy
- document close()
- refactor: push more down into startAttestation
test(runLoC): run tests from spreadsheet
- ava tests have to be created synchronously, so
turn the CSV data into a string constant
- fix parsing of empty leading fields in CSV
- add types to CSV parsing
test(runLoC): test close
10 tests passed
15 tests skipped
hush some logging
10 tests passed
15 tests skipped
- adjust offer need not have want: Attestation
- provide limited runMint access to makeLineOfCreditKit (WIP)
- provide type for notifier (RunLoCUIState)
- factor out creditPolicy.checkBorrow()
- refactor test bootstrap
- each part installs its own bundles
- bootstrapAttestation caller provides bld brand, issuer, reporter
- one reporter for many accounts / balances
- add the reporter in bootstrap
- factor out home.attMaker
- bootstrapRunLoC caller provides timer
- add testAdjust
12 tests passed
13 tests skipped
- clarify close() offer handler a bit
- test: clarify todo filter
- never mind attenuating runMint
- never mind burnSeat
feat(getRUN): vault-compatible naming
- match invitationMakers labels
- disregard address; attMaker handles it
test(getRUN): refactor stake reporter as mockBridge
feat(getRUN): only RUN balance can be adjusted, for now
- clean up test logging a bit
- style: organize imports
test(getRUN): misc refactor / clean-up
- move contractRoots near imports;
move test.before() bundle loading up
- subordinate collection utilities in Collect
- factor out theBundles type handling
- move contract start types near usage
- break lines in long type annotations
- mockBridge: rename uBrand (underlying?) to stakingBrand
feat(getRUN): align types with vaults
- makeLineOfCreditKit: move creditPolicy check inside
in order to make documentation / design simpler.
- document connection between debtAmount and minted RUN
- use return value from creditPolicy.checkBorrow
to clarify adjustBalances (up)
- burn before updating debtAmount
- never mind zeroRun
- factor BaseUIState out of UIState;
liened -> locked
- vaultState doesn't seem to be part of UIState, so
reduce it to a boolean
- never mind assertVaultIsOpen; didn't carry its weight
- makeAdjustBalancesInvitation on vault wasn't exposed; skip it
- document CreditTerms
- annotate types for minAmt()
- extract from test-runLoC.js - declare StakingAuthority type
caller provides installations rather than bundles
- prune bootstrapRunLoC.js
- committee caller reserves addresses - send poserInvitation to econ committee "chair"
provide to bootstrap as vatParameters.argv.economicCommitteeAddresses
This reverts commit f694b1a.
WIP: edit logging tweak in vats - format brands, amounts, ratios in error messages - test-getRUN: reuse startGetRun from econ-behaviors - startGetRun: - provide creatorFacet - add config for price, ratio - consume lienBridge rather than bridgeManager
- handle failing steps
Using lienBridge isn't something normal clients can do.
2 tests failing
client should get it from attMaker
without earlier test harness
dckc
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
goal: closes: #3788
Description
mostly asking the ci robots for review at this point
Security Considerations
IOU
Documentation Considerations
the usual for our contracts, at least
Testing Considerations
IOU, but see #3788 for some