Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(attestation): handle return of empty attestation #5147

Merged
merged 1 commit into from
Apr 19, 2022
Merged

fix(attestation): handle return of empty attestation #5147

merged 1 commit into from
Apr 19, 2022

Conversation

dckc
Copy link
Member

@dckc dckc commented Apr 19, 2022

@samsiegart ran into a bug in handling return of empty attestation:
https://gist.github.com/samsiegart/da0a5a519cc20ec343d962abae1317ef

refs: #3788

Testing Considerations

includes unit test

@dckc dckc requested a review from samsiegart April 19, 2022 03:44
@dckc dckc requested a review from turadg as a code owner April 19, 2022 03:44
@dckc dckc added the automerge:rebase Automatically rebase updates, then merge label Apr 19, 2022
@mergify mergify bot merged commit 35772a5 into master Apr 19, 2022
@mergify mergify bot deleted the 3788-ret-empty branch April 19, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turadg turadg turadg approved these changes

@samsiegart samsiegart samsiegart approved these changes

Assignees
No one assigned
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dckc @turadg @samsiegart