Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(cosmic-swingset): Improve makeChainStorage parameters #5292

Merged
merged 2 commits into from
May 6, 2022
Merged

refactor(cosmic-swingset): Improve makeChainStorage parameters #5292

merged 2 commits into from
May 6, 2022

Conversation

gibson042
Copy link
Member

Description

Replace the confusing imp and exp parameters with named fromChainShape and toChainShape options, and also rename obj in get and commit in anticipation of non-object values for #4558.

Security Considerations

n/a

Documentation Considerations

n/a

Testing Considerations

n/a

@gibson042 gibson042 added the cosmic-swingset package: cosmic-swingset label May 4, 2022
@gibson042 gibson042 requested a review from michaelfig May 4, 2022 23:41
@gibson042 gibson042 self-assigned this May 4, 2022
@gibson042 gibson042 added the code-style defensive correctness patterns; readability thru consistency label May 4, 2022
@gibson042 gibson042 mentioned this pull request May 4, 2022
Merged
michaelfig
michaelfig approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gibson042 gibson042 added the automerge:rebase Automatically rebase updates, then merge label May 6, 2022
@Tartuffo Tartuffo force-pushed the gibson-2022-05-makechainstorage-parameters branch from 27c8b47 to d395cbf Compare May 6, 2022 02:17
@mergify mergify bot merged commit a1d8251 into master May 6, 2022
@mergify mergify bot deleted the gibson-2022-05-makechainstorage-parameters branch May 6, 2022 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelfig michaelfig michaelfig approved these changes

Assignees

@gibson042 gibson042

Labels
automerge:rebase Automatically rebase updates, then merge code-style defensive correctness patterns; readability thru consistency cosmic-swingset package: cosmic-swingset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gibson042 @michaelfig