This repository has been archived by the owner on Feb 13, 2024. It is now read-only.
AmountMath rename, jsdoc type fix, extra await #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhofman
commented
May 21, 2021
|
@warner looks like the Node 12 drop broke the faucet tests. |
katelynsills
approved these changes
May 21, 2021
This was referenced May 21, 2021
mhofman
force-pushed
the
mhofman/spinup-fixes
branch
from
6600476 to
ceefd5e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While going through the faucet as part of following the Starting a project guide, I noticed a few issues, fixed in this PR:
amountMathis deprecated and replaced byAmountMath. This was renamed throughout inagoric-sdkbut not in this repo.bundleSourceis async and returns a Promise. It wasawaited correctly but VS code was complaining about unnecessaryawait.mintPaymentwasn't typed so VS Code couldn't provide code hinting for theseatargument.awaitare unnecessary in the test files:zoe.startInstance()acceptsERef<Installation>(I'm hoping in the future we can automatically pipeline this usage)seatis only used withE()soawaiting would prevent pipelining.