-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite loadgen to use a dedicated asset #71
Conversation
default to faucet
Allow overriding docker image in revision queue script
fix location of local-solo state
Re-enable AMM
I'll take a look as-is and let you know if I'd rather have something else... |
a3d04eb
to
5b80462
Compare
Oops sorry, I thought this was a lot of commits to review one by one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spent a little time looking at all the code in the PR both by-commit and by-file and it (5b80462) looks OK. I'm not entirely confident that I understand the code well enough to maintain it, but I'm willing to risk it.
I wonder about moving some of the agent / task stuff into agoric-sdk tests to catch integration problems earlier.
I did not verify that I can run it. I wonder if @arirubinstein is interested to try it out? I don't suppose that's critical to landing this PR, though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I only did a cursory review, but didn't see any problems.
Add boostrap config support to testnet profile
I added a couple commits to handle |
Closes #69
Refs Agoric/agoric-sdk#4634
Best reviewed commit-by-commit
Agoric/agoric-sdk#4541 removed the AMM, VaultFactory and demo assets from the default bootstrap. While the demo config does have the AMM and VaultFactory enabled, it doesn't contain any assets the loadgen could use for its tasks.
Agoric/agoric-sdk#4641 added the ability for the loadgen to bless an asset as usable with vaults. This PR mainly updates the loadgen to create its own asset, create an AMM pool, fund it with that asset and some RUN, and bless the asset for usage with the VaultFactory.
This PR ends up as a complete rewrite of the task prepare steps, and make major changes to the tasks themselves. Some noteworthy changes:
Amount
were previously shared)I have tested this change against a range of previous revisions to insure backwards compatibility. If the vaultFactoryCreator isn't available, the prepare step attempts to fallback to a demo asset (
USDC
), if available. In the worst case, thevault
task will not be functional, but theamm
task should always be available with the new dedicated loadgen asset.