Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update device-detector.service.ts #143

Merged
merged 2 commits into from
Mar 18, 2020
Merged

Update device-detector.service.ts #143

merged 2 commits into from
Mar 18, 2020

Conversation

BruneXX
Copy link
Contributor

@BruneXX BruneXX commented Mar 17, 2020

Please add this change when you can, is to solve the universal issue with window undefined. Thanks

@BruneXX
Copy link
Contributor Author

BruneXX commented Mar 17, 2020

Fix for #141

@BruneXX
Copy link
Contributor Author

BruneXX commented Mar 18, 2020

Hi guys, can you please check my pull request? thanks!

@BruneXX
Copy link
Contributor Author

BruneXX commented Mar 18, 2020 •
edited
Loading

I've updated the pull request with a new code, because after fix the first validation is throwing a new error:

(navigator !== 'undefined' && navigator.platform === 'MacIntel' && navigator.maxTouchPoints > 1))) {
                     ^

ReferenceError: navigator is not defined
at DeviceDetectorService.isTablet (/dist/server/main.js:205082:22)

@AhsanAyaz
Copy link
Owner

LGTM!
Thanks for the contribution @BruneXX 🙂

@AhsanAyaz AhsanAyaz merged commit 2ab8a50 into AhsanAyaz:master Mar 18, 2020
@AhsanAyaz AhsanAyaz mentioned this pull request Mar 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BruneXX @AhsanAyaz