fix: Reduce the stalled logging for snapshot #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facetoe
reviewed
Jun 24, 2024
pghoard/basebackup/delta.py
Outdated
| @@ -99,6 +99,7 @@ def progress_callback(progress_step: ProgressStep, progress_data: ProgressMetric | |||
| progress_step.value, progress_data["handled"], elapsed | |||
| ) | |||
| else: | |||
| self.last_flush_time = time.monotonic() | |||
There was a problem hiding this comment.
This would be better at the outer if, no need to have it in each branch. Also can we improve the log messages to better reflect what is happening? Right now it is a bit confusing.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #625 +/- ##
==========================================
- Coverage 91.01% 90.70% -0.32%
==========================================
Files 31 31
Lines 4917 4957 +40
==========================================
+ Hits 4475 4496 +21
- Misses 442 461 +19
|
sebinsunny
force-pushed
the
sebinsunny-reduce-the-snapshot-stalled-log
branch
from
a9c631a to
3933b55
Compare
sebinsunny
commented
Jun 25, 2024
| status = "FAILED" if not result.success else "successfully" | ||
| log_msg = f"{operation_type.capitalize()} of key: {key}, " \ | ||
| log_msg = f"{oper.capitalize()} of key: {key}, " \ |
There was a problem hiding this comment.
Reused oper and already contained the necessary info
sebinsunny
commented
Jun 25, 2024
| self.metrics.gauge("pghoard.seconds_since_backup_progress_stalled", 0, tags=tags) | ||
| self.log.info( | ||
| "Updated snapshot progress for %s to %d files; elapsed time since last check: %.2f seconds.", |
There was a problem hiding this comment.
It confuses operators, and because it doesn't log frequently, we might think it is stuck. Because of progress_data["handled"] value
sebinsunny
force-pushed
the
sebinsunny-reduce-the-snapshot-stalled-log
branch
from
3933b55 to
7e3d0bf
Compare
Reduce the stalled logging for the snapshot process. Previously, we were not resetting last_flush_time, resulting in a lot of logs being printed if the previous base backup failed and the current progress surpassed the previous base backup progress for the snapshot process
sebinsunny
force-pushed
the
sebinsunny-reduce-the-snapshot-stalled-log
branch
from
7e3d0bf to
e1ac0bb
Compare
facetoe
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce the stalled logging for the snapshot process. Previously, we were not resetting last_flush_time, resulting in a lot of logs being printed if the previous base backup failed and the current progress surpassed the previous base backup progress for the snapshot process
About this change - What it does
Resolves: #xxxxx
Why this way