Fix prefetch logic #638
Merged
Fix prefetch logic #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rdunklau
commented
Feb 20, 2025
rdunklau
commented
- do not prefetch timeline files
- adapt to PostgreSQL behaviour from the past 12 years and do not skip 0xFF WAL files.
We don't have many timeline files, so it is not critical to prefetch those, and can lead to database corruption if we try to download one, abort the download, and try to delete it afterwards while the server has promoted itself. The same kind of pitfalls may exist for WAL files themselves.
rdunklau
force-pushed
the
rdunklau/fix_timeline_disappearing
branch
from
95c0aed to
5b1525e
Compare
packi
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.