Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

One more occurence of making pg_wal contents disappear #639

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

rdunklau
Copy link
Contributor

If PostgreSQL asks for a file, we need to copy it there not rename it if it already exists.

This is the case when PG asks for a timeline to be copied over to RECOVERYTIMELINE.

About this change - What it does

Resolves: #xxxxx

Why this way

@rdunklau rdunklau force-pushed the rdunklau/fix_timeline_disappearing branch from e926f26 to 390232f Compare February 25, 2025 08:59
@rdunklau rdunklau force-pushed the rdunklau/fix_timeline_disappearing branch from f89e5aa to 390232f Compare February 26, 2025 07:53
@rdunklau
Copy link
Contributor Author

rdunklau commented Feb 26, 2025

The code scanning result are wrong, as the paths are actually validated.
I merged the auto suggestions yesterday to give it a try, but they are actually wrong, and more importantly beside the point of this PR as they were already there.

@rdunklau rdunklau force-pushed the rdunklau/fix_timeline_disappearing branch 2 times, most recently from e841a45 to 5edb688 Compare February 26, 2025 10:41
If PostgreSQL asks for a file, we need to copy it there not rename it if
it already exists.

This is the case when PG asks for a timeline to be copied over to
RECOVERYTIMELINE.
@rdunklau rdunklau force-pushed the rdunklau/fix_timeline_disappearing branch from 5edb688 to bc69bc6 Compare February 26, 2025 11:47
@packi packi merged commit 8ef6342 into main Feb 26, 2025
6 checks passed
@packi packi deleted the rdunklau/fix_timeline_disappearing branch February 26, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants