State channel notes from matt 2019-09-30 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MathieuDutSik the
git diffand commit messages below should hopefully help address your first two questions from this afternoon, and I've made note of some other misc bits and pieces as well.With respect to
shhdocumentation I'm not yet familiar enough to really help - sorry. I've found it difficult to find reliableweb3docs too, unfortunately.For the fourth problem we discussed I think there are several issues upstream of
bobShootandaliceShootthat'll need to be addressed first, so I haven't dug into those yet.No need to merge this PR into your branch if you'd rather not - I just wanted some way to annotate your branch without directly messing with it.