fix: Add dos2unix and file commands for Windows compatibility #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add dos2unix package for line ending conversion - Add file package for format verification - Ensure proper entrypoint.sh handling - Fix Docker build issues on Windows environment
rbren
reviewed
Feb 27, 2025
| @@ -32,6 +32,15 @@ FROM python:3.12.3-slim AS openhands-app | |||
|
|
|||
| WORKDIR /app | |||
|
|
|||
| # 必要なパッケージをすべてインストール | |||
There was a problem hiding this comment.
Can you revert these comments or translate to english?
rbren
reviewed
Feb 27, 2025
|
|
||
| # その後entrypoint.shをコピーして処理 | ||
| COPY containers/app/entrypoint.sh /app/entrypoint.sh | ||
| RUN chmod +x /app/entrypoint.sh && \ |
There was a problem hiding this comment.
I'm worried that we lost the chown here
There was a problem hiding this comment.
you are right, reverting those
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Docker Build Issues for Windows Environment
Changes
Add required packages to Dockerfile
Improve entrypoint.sh handling
Rationale
Testing
Error Before Fix
Fixes #6905