-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RecallObservations for retrieval of prompt extensions #6909
base: main
Are you sure you want to change the base?
Conversation
This looks clean so far. I'm a fan of moving what we can to the event stream: much better visibility than modifying messages in-place, and I think leaning into the pub-sub approach is a good way to add extra functionality without having to tip-toe around the agent/controller/system control flow. |
I like this idea better than what I did in #6526! Happy to close that PR in favor of this one |
a602caf
to
870b08b
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2689d11
to
c25701f
Compare
This is starting to work:
|
Make microagents available in the event stream as recall observations (accessible from the UI, LLM)
on_event
, initializationconversation_memory
- move context/prompt manager; handle RecallObs, event->messageRecallObs
should be before theuser message
in the messages to the LLM?Other expected outcomes:
Cc: @xingyaoww
I'd love your opinion about this idea. It's basically an alternative to 6526, I was curious to see roughly how it looks like, so we can maybe see if it makes sense.
This PR proposes to refactor prompt extensions into recalled observations:
Not ready for review, just some food for discussion.
Cc: @csmith49
Link of any specific issues this addresses
Fix #6535