Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] split runtime initialization (create, connect, init) in cli scripts #7036

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

enyst
Copy link
Collaborator

@enyst enyst commented Mar 1, 2025

Give a summary of what the PR does, explaining any non-trivial design decisions.

This PR proposes to:

  • fix a regression in Add selected_repo to command line #6949 where not all occurrences were handled, resulting in a double call to runtime.connect in a couple of entry points (eval_infer.py, one method in the resolver)
  • do runtime initialization in three basic steps (create, connect, initialize)

I was just looking to clean up the runtime from agent, when I saw that not all occurrences were handled previously. 😓 We also have documentation that specifies connect so this PR proposes to restore that part (the separate create and connect), and add an initialize for the specific cases of selected_repo in cli and headless.


To run this PR locally, use the following command:

docker run -it --rm   -p 3000:3000   -v /var/run/docker.sock:/var/run/docker.sock   --add-host host.docker.internal:host-gateway   -e SANDBOX_RUNTIME_CONTAINER_IMAGE=docker.all-hands.dev/all-hands-ai/runtime:19499fc-nikolaik   --name openhands-app-19499fc   docker.all-hands.dev/all-hands-ai/openhands:19499fc

@enyst enyst changed the title [Refactor] split runtime initialization in three steps (create, connect, init) [Refactor] split runtime initialization in three steps (create, connect, init) in cli scripts Mar 1, 2025
@enyst enyst changed the title [Refactor] split runtime initialization in three steps (create, connect, init) in cli scripts [Refactor] split runtime initialization (create, connect, init) in cli scripts Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant