Fix RunningAverageRssiFilter.setSampleExpirationMilliseconds
#523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cupakromer
reviewed
Jun 6, 2017
| @@ -17,7 +17,7 @@ | |||
|
|
|||
| private static final String TAG = "RunningAverageRssiFilter"; | |||
| public static final long DEFAULT_SAMPLE_EXPIRATION_MILLISECONDS = 20000; /* 20 seconds */ | |||
| private static long sampleExpirationMilliseconds = DEFAULT_SAMPLE_EXPIRATION_MILLISECONDS; | |||
| protected static long sampleExpirationMilliseconds = DEFAULT_SAMPLE_EXPIRATION_MILLISECONDS; | |||
There was a problem hiding this comment.
It looks like this may only be needed to have higher access for testing. Instead of exposing this as protected, which makes it exposed in public documentation, could we keep it private and use a getter with package-private access instead?
@RestrictTo(TESTS)
static long getSampleExpirationMilliseconds() {
return sampleExpirationMilliseconds;
}
cupakromer
added a commit
that referenced
this pull request
Dec 12, 2017
This fixes #627 which is a regression of #523 (AltBeacon/android-beacon-library-reference#30). It was introduced in commit f084042 (PR #484) where the `RunningAverageRssiFilter` has it's value constantly reset after every cycle in [`RangedBeacon#commitMeasurements`](f084042#diff-65311818bc092d4192549ca6a7932a8aR50).
cupakromer
added a commit
that referenced
this pull request
Dec 12, 2017
This fixes #627 which is a regression of #523 (AltBeacon/android-beacon-library-reference#30). It was introduced in commit f084042 (PR #484) where the `RunningAverageRssiFilter` has it's value constantly reset after every cycle in [`RangedBeacon#commitMeasurements`](f084042#diff-65311818bc092d4192549ca6a7932a8aR50).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ability to configure this setting was broken as reported in AltBeacon/android-beacon-library-reference#30. This change makes the API work as intended so the documentation is correct.