Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polkadot-sdk: v1.9.0 -> v1.13.0 #944

Merged
merged 38 commits into from
Jun 27, 2024
Merged

Conversation

FlorianFranzen
Copy link
Collaborator

@FlorianFranzen FlorianFranzen commented Jun 19, 2024

Description

This updates the polkadot-sdk from v1.9 to v1.13 and includes the following additional features:

  • Add support for authority discovery
  • Add support for metadata hashes
  • Use latest runtime macros
  • Node now supports additional commands and hardware benchmarking
  • Support sync snapshots and other chain spec extensions
  • Update to latest networking and cli interface
  • Remove native executor
  • Use workspace and umbrella crates to simplify dependency management

So far only pallet was prepared to switch to the umbrella pallet as well, but it seems there is still some issue that blocks compilation right now, so I will port those at a later point.

Currently uses a slightly patched version of the polkadot-sdk that includes this fix.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

I ran a subset of the integration tests.

Code review prechecks:

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Inline comments have been added for each method
  • I have made corresponding changes to the documentation
  • Code changes introduces no new problems or warnings
  • Test cases have been added
  • Dependent changes have been merged and published in downstream modules

@FlorianFranzen FlorianFranzen force-pushed the florian/substrate-update branch from d149ace to 9a67907 Compare June 19, 2024 13:34
@FlorianFranzen FlorianFranzen added enhancement New feature or request ready-for-review PR author(s) done with coding and reviewer[s] can start priority: critical labels Jun 19, 2024
Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine as long as it works

@FlorianFranzen FlorianFranzen force-pushed the florian/substrate-update branch 5 times, most recently from dd3ebf9 to 99f4e0e Compare June 24, 2024 19:10
@FlorianFranzen
Copy link
Collaborator Author

@penumbra23 I rebased all commits on the latest developement and fixed the remaining conflicts. I would welcome a final review, so we can merge and deploy to development.

@FlorianFranzen FlorianFranzen force-pushed the florian/substrate-update branch 6 times, most recently from 897efc4 to 1f66e82 Compare June 27, 2024 09:26
Copy link
Collaborator

@dvc94ch dvc94ch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try it. @penumbra23 when would you like to merge this?

@FlorianFranzen FlorianFranzen force-pushed the florian/substrate-update branch from 7da1ee2 to 04ce517 Compare June 27, 2024 14:14
@FlorianFranzen FlorianFranzen force-pushed the florian/substrate-update branch from 04ce517 to ccea66f Compare June 27, 2024 14:19
@FlorianFranzen FlorianFranzen merged commit 65544d7 into development Jun 27, 2024
13 of 18 checks passed
@FlorianFranzen FlorianFranzen deleted the florian/substrate-update branch June 27, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority: critical ready-for-review PR author(s) done with coding and reviewer[s] can start
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants