Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow equality comparisons between [Token] slices. #28

Closed
Anders429 opened this issue Dec 21, 2023 · 1 comment · Fixed by #32
Closed

Disallow equality comparisons between [Token] slices. #28

Anders429 opened this issue Dec 21, 2023 · 1 comment · Fixed by #32

Comments

@Anders429
Copy link
Owner

Allowing comparisons between arrays of tokens may result in unexpected behavior with #22. The equality comparison with Tokens is specialized to do correct comparison, but if the user compares two arrays somehow they may be confused by the comparison not being correct.
@Anders429
Copy link
Owner Author

The way to resolve this is by removing the ability to compare between Tokens. This is fine, since the PartialEq impl was just an implementation detail for comparing the full serialization output anyway.

This was referenced Dec 23, 2023
Merged
Merged
@Anders429 Anders429 linked a pull request Dec 23, 2023 that will close this issue
Version 0.7.0. #32
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 0.7.0. Anders429/serde_assert
1 participant
@Anders429