Introduce internal CanonicalToken type to simplify token equality comparisons
#31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #31 +/- ##
==========================================
- Coverage 98.18% 98.00% -0.19%
==========================================
Files 3 3
Lines 6446 6254 -192
==========================================
- Hits 6329 6129 -200
- Misses 117 125 +8 ☔ View full report in Codecov by Sentry. |
|
Loss in code coverage is acceptable. All of the missing lines are in tests and seem to be false positives. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both #27 and #28.
Canonical tokens separate out the internal behavior of tokens from the external behavior. External behavior needs
Unorderedtokens, but internal doesn't; similarly, internal behavior just needs to emitCanonicalTokens from theSerializer, which will never needUnorderedtokens. Separating these two cases vastly simplifies equality comparisons, removing the need for a dependency onhashbrown.