Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overhaul of Builder APIs. #26

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Overhaul of Builder APIs. #26

merged 8 commits into from
Dec 19, 2023

Conversation

Anders429
Copy link
Owner

Fixes #17.

This fixes a few things in the de::Builder API. Firstly, this makes it impossible for build() to panic, instead requiring that Builder is always in a valid state (meaning tokens is always set). Additionally, the internals of Builder are refactored to no longer use any Options, as well as collecting the tokens preemptively to prevent having to clone an iterator.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4d3d701) 98.23% compared to head (4a616e2) 98.18%.
Report is 1 commits behind head on dev.

Files Patch % Lines
src/ser.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #26      +/-   ##
==========================================
- Coverage   98.23%   98.18%   -0.05%     
==========================================
  Files           3        3              
  Lines        6569     6446     -123     
==========================================
- Hits         6453     6329     -124     
- Misses        116      117       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Anders429
Copy link
Owner Author

Also reworked ser::Builder in a similar way, removing the Options.

@Anders429 Anders429 changed the title Overhaul of de::Builder. Overhaul of Builder APIs. Dec 19, 2023
@Anders429 Anders429 merged commit e8419b8 into dev Dec 19, 2023
@Anders429 Anders429 deleted the builder branch December 19, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant