Add handling of exceptions to named_thread_pool #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg7mdp
reviewed
Jan 20, 2023
greg7mdp
approved these changes
Jan 25, 2023
spoonincode
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exceptions leaking out and terminating thread in
named_thread_poolprovide ability to specify an exception handler. In all our non-test cases we want the application to shutdown.Pulled in changes from #592 that allows for delayed start of the thread pool.
Added some tests for
named_thread_pool.As discussed here: #665 (comment) Moved to always using delayed start with number of threads provided in
start(). Also moved specification of exception handler tostart()as that is cleaner than requiring it in the constructor.