Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean database after the after block #1365

Merged
merged 1 commit into from
Jul 9, 2015
Merged

clean database after the after block #1365

merged 1 commit into from
Jul 9, 2015

Conversation

afomi
Copy link

@afomi afomi commented Jul 9, 2015

goal: to eliminate PG deadlock issues when running specs

@saterus
Copy link

saterus commented Jul 9, 2015

Can you include a little more context? What is the difference between #append and #append_after? What lead you to believing this fixes the deadlock?

@afomi
Copy link
Author

afomi commented Jul 9, 2015

sure thing @saterus. The links below pointed me toward append_after. Alternatively, people recommended using around blocks as well, but I wanted to try this first, since it was the smallest change.

The difference is: append_after Adds block to the back of the list of after blocks in the same scope (:example, :context, or :suite). - I thought this would give it enough time to let the database locks clear.

I saw append_after in this one:

@saterus
Copy link

saterus commented Jul 9, 2015

👍

@mikem
Copy link

mikem commented Jul 9, 2015

👍

afomi added a commit that referenced this pull request Jul 9, 2015
clean database after the after block
@afomi afomi merged commit d584dc5 into master Jul 9, 2015
@afomi afomi deleted the tryfix-deadlocks branch July 9, 2015 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants