Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apipie versions upper 0.5.6 doesn't generate docs for rails 4.2 #622

Closed
korrs opened this issue Jun 3, 2018 · 6 comments · Fixed by #633
Closed

Apipie versions upper 0.5.6 doesn't generate docs for rails 4.2 #622

korrs opened this issue Jun 3, 2018 · 6 comments · Fixed by #633

Comments

@korrs
Copy link

korrs commented Jun 3, 2018

And i found commit that brakes the generation of docs. When i remove changes in this commit all works excellent and all specs in gem completed without errors(with various rails versions).

@iNecas
Copy link
Member

iNecas commented Jun 4, 2018

Would you mind open a PR that would conditionally use one way of the other based on what rails version is around?

@korrs
Copy link
Author

korrs commented Jun 6, 2018

👌

@korrs
Copy link
Author

korrs commented Jun 15, 2018

@iNecas I don't understand what problem solves mentioned PR. I created rails 5.2 app, install 0.5.6 apipie version(before commit that brakes generating docs in rails 4.2), run specs and all docs generate successfully!

@korrs
Copy link
Author

korrs commented Jul 12, 2018

@iNecas can i revert changes in mentioned commit?

@iNecas
Copy link
Member

iNecas commented Jul 12, 2018

I would rather see a condition on Rails version, and use the old variant for rails < 5. I bet there was a reason for doing the original patch in some environments (don't remember the details though)

@morr
Copy link

morr commented Sep 18, 2018

@iNecas in my project docs generation is broken in rails 5.2 with latest apipie version.
When i reverted changes from e3eab0a docs generation starts working again.

RomanKapitonov pushed a commit to RomanKapitonov/apipie-rails that referenced this issue Oct 11, 2018
RomanKapitonov pushed a commit to RomanKapitonov/apipie-rails that referenced this issue Oct 11, 2018
RomanKapitonov pushed a commit to RomanKapitonov/apipie-rails that referenced this issue Oct 11, 2018
yoav-p6 pushed a commit to parallel-6/apipie-rails that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants