-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apipie versions upper 0.5.6 doesn't generate docs for rails 4.2 #622
Comments
Would you mind open a PR that would conditionally use one way of the other based on what rails version is around? |
👌 |
@iNecas I don't understand what problem solves mentioned PR. I created rails 5.2 app, install 0.5.6 apipie version(before commit that brakes generating docs in rails 4.2), run specs and all docs generate successfully! |
@iNecas can i revert changes in mentioned commit? |
I would rather see a condition on Rails version, and use the old variant for rails < 5. I bet there was a reason for doing the original patch in some environments (don't remember the details though) |
And i found commit that brakes the generation of docs. When i remove changes in this commit all works excellent and all specs in gem completed without errors(with various rails versions).
The text was updated successfully, but these errors were encountered: