Fix Rails 5.1 deprecations #530
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domcleal
suggested changes
Mar 22, 2017
There was a problem hiding this comment.
- The tests indicate the min version of Rails needs increasing to 4.1 to support
render :plain, which wasn't in 4.0. Updateapipie-rails.gemspecto depend on rails>= 4.1, remove the fileGemfile.rails40and also from.travis.yml. - Remove Ruby 1.9.3 from
.travis.ymlso it's no longer tested.
Otherwise it's working well for me on Rails 5.1.
nunosilva800
force-pushed
the
fix-rails5.1-deprecations
branch
from
0025534 to
a83ae47
Compare
nunosilva800
force-pushed
the
fix-rails5.1-deprecations
branch
from
a83ae47 to
7217434
Compare
domcleal
approved these changes
Mar 22, 2017
|
Done! :D |
|
Added: whitesmith#1 |
|
Can this be merged? |
|
apipie-rails-0.5.0 is out, including this change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several deprecated methods being removed in Rails 5.1
(rails/rails#27035)
This also enforces Ruby 2.0 or higher