Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Original pointer network [DON'T MERGE] #23

Closed
wants to merge 160 commits into from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Dec 25, 2023

This is just to backup the original one. Code is mostly taken from https://github.com/ArneBinder/pie-document-level/pull/26

…t rename classes and shorten and modify the tests
…Decoder, PointerNetworkEncoderDecoder) and implementations to taskmodule.components.seq2seq
…ent_type and tokenized_document_type properties
…pare reporting the number exact numbers of invalid encodings
…and sanitize_sequence() to get_valid_relation_encodings()
…_relation_encodings() to decode_relations() and directly try to decode there (catch exceptions and collect them in errors dict)
@codecov-commenter
Copy link

Codecov Report

Attention: 522 lines in your changes are missing coverage. Please review.

Comparison is base (8522938) 96.36% compared to head (89874d0) 86.48%.

Files Patch % Lines
...models/components/pointer_network/modeling_bart.py 62.74% 231 Missing ⚠️
src/pie_modules/models/pointer_network_model.py 80.95% 68 Missing ⚠️
...odules/models/components/pointer_network/losses.py 53.43% 61 Missing ⚠️
...les/models/components/pointer_network/interface.py 52.63% 36 Missing ⚠️
...modules/models/components/pointer_network/utils.py 60.43% 36 Missing ⚠️
...les/models/components/pointer_network/generator.py 87.50% 31 Missing ⚠️
...dules/pointer_network_taskmodule_for_end2end_re.py 94.45% 20 Missing ⚠️
...ponents/pointer_network/bart_as_pointer_network.py 91.50% 13 Missing ⚠️
.../models/components/pointer_network/pointer_head.py 93.10% 6 Missing ⚠️
...pie_modules/taskmodules/pointer_network/metrics.py 95.41% 6 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
- Coverage   96.36%   86.48%   -9.88%     
==========================================
  Files          23       38      +15     
  Lines        1731     4330    +2599     
==========================================
+ Hits         1668     3745    +2077     
- Misses         63      585     +522     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder
Copy link
Owner Author

Since #10 is merged, this is not required anymore.

@ArneBinder ArneBinder closed this Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants