Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

derive PyTorchIETaskmoduleModelHubMixin from HyperparametersMixin #63

Closed
ArneBinder opened this issue Feb 14, 2022 · 0 comments · Fixed by #65
Closed

derive PyTorchIETaskmoduleModelHubMixin from HyperparametersMixin #63

ArneBinder opened this issue Feb 14, 2022 · 0 comments · Fixed by #65

Comments

@ArneBinder
Copy link
Owner

ArneBinder commented Feb 14, 2022

This will allow to just call self.save_hyperparameters() in the __init__() of any Taskmodule (instead of passing all relevant parameters to super().__init__()) and config could be implemented (in analogy to PyTorchIEModel) as:

    def _config(self) -> Dict[str, Any]:
        config = dict(self.hparams)
         config["taskmodule_type"] = self.__class__.__name__
        return config
ArneBinder added a commit that referenced this issue Feb 14, 2022
@ArneBinder ArneBinder linked a pull request Feb 16, 2022 that will close this issue
ArneBinder added a commit that referenced this issue Feb 17, 2022
ChristophAlt pushed a commit that referenced this issue Feb 17, 2022
Co-authored-by: Arne Binder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant