Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Auto classes in readme #165

Merged
merged 4 commits into from
May 4, 2022
Merged

use Auto classes in readme #165

merged 4 commits into from
May 4, 2022

Conversation

ArneBinder
Copy link
Owner

No description provided.

@ArneBinder ArneBinder requested a review from ChristophAlt May 3, 2022 15:39
re_model = TransformerTextClassificationModel.from_pretrained(model_name_or_path)

re_pipeline = Pipeline(model=re_model, taskmodule=re_taskmodule, device=-1)
re_pipeline = AutoPipeline.from_pretrained("pie/example-re-textclf-tacred", device=-1)
Copy link
Collaborator

@ChristophAlt ChristophAlt May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the examples without AutoX to demonstrate how it actually works?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. Both or just this one?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say both. We'll explain the use of AutoX in the documentation and README.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 3403b35.

@ChristophAlt
Copy link
Collaborator

Just minor comments, otherwise it looks good! 👍

@ArneBinder ArneBinder changed the title Auto examples & readme adaptation use Auto classes in readme May 4, 2022
@ChristophAlt ChristophAlt merged commit 9d18f98 into main May 4, 2022
@ChristophAlt ChristophAlt deleted the auto_examples branch May 4, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants