Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust generic document types #359

Merged
merged 3 commits into from
Oct 19, 2023
Merged

adjust generic document types #359

merged 3 commits into from
Oct 19, 2023

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Oct 19, 2023

With this PR, we modify the generic document types: rename the annotation layers to reflect the annotation type and also reflect that in the document type names.

IMPORTANT: This also changes the default values for annotation layer related parameters in the taskmodules to work with the changes out of the box, i.e.

  • TransformerRETextClassificationTaskModule: relation_annotation becomes binary_relations (formerly relations)
  • TransformerSeq2SeqTaskModule:
    • entity_annotation becomes labeled_spans (formerly entities), and
    • relation_annotation becomes binary_relations (formerly relations)
  • TransformerSpanClassificationTaskModule: entity_annotation becomes labeled_spans (formerly entities)
  • TransformerTokenClassificationTaskModule: entity_annotation becomes labeled_spans (formerly entities)

The generic document types are primarily for dataset auto-conversion. However, because we change the default values for the taskmodules as described above, this is a breaking change.

@ArneBinder ArneBinder added the breaking Breaking Changes label Oct 19, 2023
@ArneBinder ArneBinder merged commit 421f618 into main Oct 19, 2023
@ArneBinder ArneBinder deleted the improve_document_types branch October 19, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant