Unittests for TransformerSpanClassificationModel

[ChristophAlt]

No description provided.

[ArneBinder]

This looks quite good, as far as I understand it.

Just one thing: does this also sufficiently test the functionality of _start_end_and_span_length_span_index? I do not really get, what's happening there, so this might be already covered. Or could you maybe add a small comment to that function describing what it does?

[ChristophAlt]

This looks quite good, as far as I understand it.

Just one thing: does this also sufficiently test the functionality of _start_end_and_span_length_span_index? I do not really get, what's happening there, so this might be already covered. Or could you maybe add a small comment to that function describing what it does?

Right now it does not directly test the functionality of _start_end_and_span_length_span_index. I'll add another test case for this. The function basically enumerates all spans up to a length of L for a batch of inputs and returns the start and end offset for each span, the length of the span (because we add a length embedding to each span), and the batch index (the item in the batch each span belongs to) because the span indices must be flattened (as each batch item, e.g. a sentence, has different length and thus a different number of spans).

[ArneBinder]

OK, thanks a lot for the explanation :)