Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove (Multi)LabeledMultiSpan annotations #405

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Feb 19, 2024

The LabeledMultiSpan was moved to pie-modules (and also fixed), see ArneBinder/pie-modules#59. So we remove it from pytorch-ie to mitigate any confusion caused by two implementations (note that comparison would break when comparing an instance of one with the other even if the implemented semantics are identical).

Note that this also removes _post_init_multi_span().

@ArneBinder ArneBinder added the breaking Breaking Changes label Feb 19, 2024
@ArneBinder ArneBinder changed the title Remove (Multi))LabeledMultiSpan annotations Remove (Multi)LabeledMultiSpan annotations Feb 19, 2024
@ArneBinder ArneBinder merged commit eef7905 into main Feb 19, 2024
6 checks passed
@ArneBinder ArneBinder deleted the remove_multi_span_annotations branch February 19, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking Changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant