Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipeline: cleanup argument handling #57

Merged
merged 3 commits into from
Feb 8, 2022
Merged

pipeline: cleanup argument handling #57

merged 3 commits into from
Feb 8, 2022

Conversation

ArneBinder
Copy link
Owner

This PR removes all configuration arguments from __call__ in favor of using _sanitize_parameters. This allows to set default parameters for everything in the pipeline constructor.

Changes:

  • introduce dataloader_params (similar to preprocess_params etc.) that are also returned by _sanitize_arguments
  • add function get_dataloader (gets model_inputs and dataloader_params as arguments)
  • show_pipeline_progress is part of forward_params
  • remove unused arguments from __call__

@ArneBinder ArneBinder changed the title [WIP] pipeline: cleanup argument handling pipeline: cleanup argument handling Feb 8, 2022
@ChristophAlt ChristophAlt merged commit c9432f3 into main Feb 8, 2022
@ArneBinder ArneBinder deleted the sanitize_pipeline_arguments branch February 10, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophAlt ChristophAlt Awaiting requested review from ChristophAlt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArneBinder @ChristophAlt