simplify transformer_token_classification_taskmodule #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_annotation (backwards compatible)
…quence() and _encode_text() to ease testing
…ot partition is provided to _encode_text
| single_sentence: bool = False, | ||
| sentence_annotation: str = "sentences", | ||
| partition_annotation: Optional[str] = None, | ||
| single_sentence: bool = False, # deprecated, set partition_annotation instead |
There was a problem hiding this comment.
We're still at version 0.x -- no need for backwards compatibility or deprecations, just remove it. 😃
| def _encode_text(self, text, partition: Optional[LabeledSpan] = None): | ||
| if self.partition_annotation is not None and partition is None: | ||
| raise ValueError(f"partitioning is enabled, but no partition is provided") | ||
| _text = text[partition.start : partition.end] if partition is not None else text |
There was a problem hiding this comment.
Can we agree on not using underscores for variable names. I'm sure there is a name that fits better.
|
Looks good! 👍 The unittest cleanup will be done in a different commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.