-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare CI / CD pipeline for initial release #76
Conversation
- add flake8 + plugins for linting - add darglint for linting function signature and docstrings - build docs with sphinx - removed tests from pre-commit - use nox + nox-poetry to run linting, tests, docs-build, docs-preview - completed pyproject.toml - add github workflows for tests and release
darglint seems to have issues with parsing larger google-formated docstrings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I understand the changes, they look good. I have just two minor questions.
Also, could you create one/multiple further issues for the TODOs listed in "additional Info" of the PR description that we do not forget about this? I'm not really into linting/flake8 and don't know if this a single one or separate problems that's why I did not create them myself.
Although this PR touches quite a few files, most of the changes are either additional configuration files or minor (automated) reformatting of code and other files.
Additional info: