Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly configure coverage.py #90

Merged
merged 15 commits into from
Mar 1, 2022
Merged

Properly configure coverage.py #90

merged 15 commits into from
Mar 1, 2022

Conversation

ChristophAlt
Copy link
Collaborator

  • the coverage session was incorrectly configured to run on python 3.10
  • codecov now shows failure if a PR decreases coverage and has less than 80% patch coverage
  • coverage.py fails if the code coverage is below 60%

Additional remarks:

  • I disabled macOS builds for now, because they take long and we'll focus on linux for now
  • I opted to include tests in the coverage, because it is a helpful indicator to spot problems with the unittests

@ChristophAlt ChristophAlt added build Build System and Dependencies ci Continuous Integration labels Mar 1, 2022
@ArneBinder
Copy link
Owner

This looks very cool!

But it looks like the coverage is still running over the tests, see the report in "combine coverage data and display human readable report" of the ci pipeline. We suddenly have a coverage of 60%, but I dont think we added any tests. Before it was 45%, see cov report here.

@ChristophAlt ChristophAlt merged commit 195a49b into main Mar 1, 2022
@ChristophAlt ChristophAlt removed the build Build System and Dependencies label Mar 1, 2022
@ChristophAlt ChristophAlt deleted the fix_coverage branch March 4, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants