Refactor/document typed #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
I'd prefer this version for the moment. It's less concise but more explicit about what's going on. |
…ta.document.construct_document
…ayer but allow add without annotations to create a new layer
…of new AnnotationCollection.create_layer method
ArneBinder
force-pushed
the
refactor/document_typed
branch
from
f2b29d6 to
3e0c861
Compare
|
@ChristophAlt I just rebased onto main, should be ready to merge. |
|
Looks good! Could you also adapt the examples in the README to the change? Then it should be ready to merge. |
|
@ChristophAlt The readme should be fine now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up and simplifies the Document (improved version of #93).
It contains the following changes:
annotationsandpredictionsas attributes ofDocumentwith typeAnnotationCollectionto reuse its functionalityAnnotationCollectionthat holds the attributeslabels: TypedAnnotationCollection[Label],spans: TypedAnnotationCollection[LabeledSpan], andbinary_relations: TypedAnnotationCollection[BinaryRelation](for now) and some helper functions to add annotations or enumerate the collections/layers.TypedAnnotationCollection[T_annotation]as mapping from layer names toList[T_annotation]s with some helper methods.construct_documentthat allows to easily create a Document from a text, spans and binary_relations (both as mapping from names to iterables of the respective annotations). This was previously sitting intests.helpers.document_utils, but seems to be useful also in other places than tests.TransformerRETextClassificationTaskModule: usepytest.approxto compare floats