Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib/meta: optimise platform constraint algebra #2

Open
wants to merge 1 commit into
base: lib/meta-platform-constraints
Choose a base branch
from

Conversation

adisbladis
Copy link

What was tested

  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • ...

If you (yes, you!) use the component(s) changed in this PR, please test the component(s) built from this PR and report your findings.

How can reviewers test this?

If you are a user and have a simple setup for the component(s) changed by this PR which others could use to this PR, please reply and share it with us.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Atemu
Copy link
Owner

Atemu commented Nov 15, 2024

Thank you so much for looking into this in detail again!

I assume you profiled this as you went, could you share some benchmarks?

I must also admit that I had a few more changes that I had intended to push but forgot to. It's not much but it will cause a conflict.

I will push them and ask you to please take a look at them and rebase, reverting where you think/test your version to be better. I particularly like my implementation for ANY and NONE more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants