Upgrade to nextv12 and routing update to next/router #1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ding Ma <[email protected]>
Signed-off-by: Ding Ma <[email protected]>
Signed-off-by: Ding Ma <[email protected]>
Signed-off-by: Ding Ma <[email protected]>
Signed-off-by: Ding Ma <[email protected]>
abvaidya
requested changes
Dec 3, 2021
| }; | ||
| } | ||
| export async function getServerSideProps(ctx) { | ||
| const initialProps = await Document.getInitialProps(ctx); |
There was a problem hiding this comment.
Should this be Document.getServerSideProps?
There was a problem hiding this comment.
Document object provided by next doesn't have getServerSideProps.
Signed-off-by: Ding Ma <[email protected]>
Signed-off-by: Ding Ma <[email protected]>
abvaidya
approved these changes
Dec 3, 2021
|
closes #1607 |
dvirguttman
pushed a commit
to dvirguttman/athenz
that referenced
this pull request
Mar 28, 2023
* Upgrade to nextv12 and routing update to next/router Signed-off-by: Ding Ma <[email protected]> * Fix service pages Signed-off-by: Ding Ma <[email protected]> * Fix sd build Signed-off-by: Ding Ma <[email protected]> * add old pages mapping Signed-off-by: Ding Ma <[email protected]> * Fix lint Signed-off-by: Ding Ma <[email protected]> * Fix snapshots Signed-off-by: Ding Ma <[email protected]> * Update based on comments Signed-off-by: Ding Ma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ding Ma [email protected]