add retry logic and feature flag in microsegmentation UI #1710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekhar1996
force-pushed
the
microsegUI
branch
2 times, most recently
from
533c49a to
9dae700
Compare
|
Could you please add a little more details in comment as to what this PR is about? |
abvaidya
added
the
in-progress
|
Creation of microsegmentation policy involves creation of policy and assertion (if it doesn't exist) and then we need to fetch the assertionID of the newly created assertion to add assertionConditions. I have added a retry logic for fetching the policy/assertion after creating it to account for read-after-write inconsistency. We try to fetch the policy twice with a 1 second sleep interval. I have also added a feature flag for the microsegmentation page. Currently we have a feature flag for the entire UI that we use to show/hide tabs. The new feature flag can be used to hide specific features in a page while under development. |
chandrasekhar1996
force-pushed
the
microsegUI
branch
3 times, most recently
from
f01ba6e to
7543913
Compare
pratikgote
suggested changes
Jan 6, 2022
ui/src/__tests__/components/microsegmentation/AddSegmentation.test.js
Outdated
Show resolved
Hide resolved
Signed-off-by: craman <[email protected]>
chandrasekhar1996
force-pushed
the
microsegUI
branch
2 times, most recently
from
87d3fa5 to
19540de
Compare
chandrasekhar1996
force-pushed
the
microsegUI
branch
from
19540de to
f33bac3
Compare
Signed-off-by: craman <[email protected]>
chandrasekhar1996
force-pushed
the
microsegUI
branch
from
f33bac3 to
aba05a7
Compare
abvaidya
approved these changes
Jan 27, 2022
dvirguttman
pushed a commit
to dvirguttman/athenz
that referenced
this pull request
Mar 28, 2023
* add retry logic and feature flag in microsegmentation UI Signed-off-by: craman <[email protected]> * address PR comments Signed-off-by: craman <[email protected]> Co-authored-by: craman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: craman [email protected]