Add domain dependency functions to zms java and go clients #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OferLevi85
force-pushed
the
domain_dependency_zms_client
branch
from
69d8809 to
14f18ed
Compare
OferLevi85
changed the title
havetisyan
requested changes
Feb 8, 2022
libs/go/zmscli/cli.go
Outdated
| if argc == 1 { | ||
| return cli.GetDependentServiceList(dn) | ||
| } | ||
| case "get-dependent-domain-list": |
There was a problem hiding this comment.
because this command does not require a domain, it's in a wrong switch statement. it should be handled in the previous switch block where commands without the domain arguments are handled.
OferLevi85
force-pushed
the
domain_dependency_zms_client
branch
from
14f18ed to
ab1e7b0
Compare
Signed-off-by: Ofer Levi <[email protected]>
OferLevi85
force-pushed
the
domain_dependency_zms_client
branch
from
ab1e7b0 to
77cabfd
Compare
havetisyan
approved these changes
Feb 9, 2022
dvirguttman
pushed a commit
to dvirguttman/athenz
that referenced
this pull request
Mar 28, 2023
Signed-off-by: Ofer Levi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ofer Levi [email protected]