auto purge expired role/group members based on server/domain config #1941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
510a992 to
273ce6e
Compare
havetisyan
reviewed
Aug 16, 2022
servers/zms/src/main/java/com/yahoo/athenz/zms/purge/PurgeMember.java
Outdated
Show resolved
Hide resolved
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
273ce6e to
0b9909e
Compare
mendi160
commented
Aug 17, 2022
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
0b9909e to
1b82e77
Compare
mendi160
commented
Aug 22, 2022
|
|
||
| // Delete expired principals | ||
| resource ExpiredMembers DELETE "/expired-members?purgeResources={purgeResources}" { | ||
| Int32 purgeResources (optional); //defining which resources will be purged. by default all resources will be purged |
There was a problem hiding this comment.
0 - none of them will be purged
1 - only roles will be purged
2 - only groups will be purged
3/default - both of them will be purged
There was a problem hiding this comment.
let's include these details in the rdl definition, in the function description before the signature definition
mendi160
commented
Aug 22, 2022
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
1b82e77 to
d0828d1
Compare
havetisyan
requested changes
Aug 25, 2022
clients/java/zms/src/main/java/com/yahoo/athenz/zms/ZMSClient.java
Outdated
Show resolved
Hide resolved
clients/java/zms/src/main/java/com/yahoo/athenz/zms/ZMSClient.java
Outdated
Show resolved
Hide resolved
added 5 commits
August 28, 2022 23:32
Signed-off-by: mshneorson <[email protected]>
Signed-off-by: mshneorson <[email protected]>
Signed-off-by: mshneorson <[email protected]>
Signed-off-by: mshneorson <[email protected]>
Signed-off-by: mshneorson <[email protected]>
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
d0828d1 to
fa717c6
Compare
havetisyan
requested changes
Aug 30, 2022
There was a problem hiding this comment.
@mendi160 also please make sure you have go 1.19 installed which is what should be used for generating the code. also merge the master into your branch since there were some changes in the go client generation with the move to 1.19.
servers/zms/src/main/java/com/yahoo/athenz/zms/purge/PurgeResourcesEnum.java
Show resolved
Hide resolved
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
mendi160
force-pushed
the
auto_remove_expired_principals
branch
3 times, most recently
from
c4c7b9a to
d3f9cd3
Compare
2. generating the code with go 1.19 Signed-off-by: mshneorson <[email protected]>
mendi160
force-pushed
the
auto_remove_expired_principals
branch
from
d3f9cd3 to
723feda
Compare
havetisyan
requested changes
Sep 2, 2022
|
|
||
| // Delete expired principals | ||
| resource ExpiredMembers DELETE "/expired-members?purgeResources={purgeResources}" { | ||
| Int32 purgeResources (optional); //defining which resources will be purged. by default all resources will be purged |
There was a problem hiding this comment.
let's include these details in the rdl definition, in the function description before the signature definition
| @@ -1797,6 +1823,11 @@ void executePutEntity(ResourceContext ctx, String domainName, String entityName, | |||
| } | |||
| } | |||
|
|
|||
| // void executeDeleteMembership(ResourceContext ctx, String domainName, String roleName, | |||
There was a problem hiding this comment.
this one looks like hasn't been addressed so let's remove it
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
servers/zms/src/main/java/com/yahoo/athenz/zms/store/impl/jdbc/JDBCConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: mshneorson <[email protected]>
havetisyan
changed the title
dvirguttman
pushed a commit
to dvirguttman/athenz
that referenced
this pull request
Mar 28, 2023
…thenZ#1941) Signed-off-by: mshneorson <[email protected]> Co-authored-by: mshneorson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: mshneorson [email protected]