allow ssh-principals with service name based dns cnames #2122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when sia provides an ssh host certificate request where the principal is based on dns suffix or a cname one without relying on hostname, current changes now allow that support by relying on the configured hostname resolver.
So you can have an instance with service api and domain sports with dns suffix athenz.io to include the following ssh principals:
10.11.11.11 - internal private ip of the hostname
api.sports.athenz.io - service based name
bastion.sports.athenz.cloud - this is configured as cname for api.sports.athenz.io thus allowed.
the logic for the last 2 checks is part of the HostnameResolver interface implementation.