Disable Microsegmentation validation checkbox for AWS env #2173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrasekhar1996
force-pushed
the
disableValidationMicroseg
branch
2 times, most recently
from
42a5140 to
8769dc7
Compare
dvirguttman
approved these changes
May 15, 2023
chandrasekhar1996
force-pushed
the
disableValidationMicroseg
branch
from
12f6781 to
941f9dd
Compare
chandrasekhar1996
force-pushed
the
disableValidationMicroseg
branch
from
941f9dd to
d0a65fe
Compare
dvirguttman
reviewed
May 16, 2023
| // isScopeOnPrem returns true if onprem is a selected option | ||
| isScopeOnPrem() { | ||
| for (let i = 0; i < this.state.PESList.length; i++) { | ||
| if (this.state.PESList[i].scopeonprem == 'false') { |
There was a problem hiding this comment.
Since initial state is:
scopeonprem: 'true',
scopeaws: 'false',
scopeall: 'false',
In case the user checks aws in addition to on prem - it will return true instead of false - correct?
consider maybe we should change the method name to isOnlyOnPremScope ..
dvirguttman
reviewed
May 16, 2023
ui/src/__tests__/components/microsegmentation/__snapshots__/AddSegmentation.test.js.snap
Outdated
Show resolved
Hide resolved
added 5 commits
May 16, 2023 13:47
Signed-off-by: craman <[email protected]>
Signed-off-by: craman <[email protected]>
Signed-off-by: craman <[email protected]>
Signed-off-by: craman <[email protected]>
Signed-off-by: craman <[email protected]>
chandrasekhar1996
force-pushed
the
disableValidationMicroseg
branch
from
d0a65fe to
b3ac82e
Compare
dvirguttman
approved these changes
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.