replace deprecated request pkg #2180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jtsang01 <[email protected]>
jimmytsang
force-pushed
the
refactor-request-pkg
branch
from
423d140 to
348ec3b
Compare
jimmytsang
commented
May 19, 2023
| @@ -97,7 +96,7 @@ | |||
| "redux-devtools-extension": "2.13.9", | |||
| "redux-mock-store": "1.5.4", | |||
| "redux-thunk": "2.4.1", | |||
| "request": "2.88.2", | |||
| "axios": "1.4.0", | |||
There was a problem hiding this comment.
Considered using native nodejs functions but ran into connectivity errors that were not easily resolvable.
I believe this current solution using axios is appropriate for the time being as it involves very little code change and is a popular npm package that has a very active community supporting it.
Signed-off-by: jtsang01 <[email protected]>
ui/src/rdl-rest.js
Outdated
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| var url = require('url'); | |||
| var path = require('path'); | |||
| var axios = require('axios'); | |||
| var request = require('request'); | |||
There was a problem hiding this comment.
need to remove this
|
package-lock.json will also need to be updated |
Signed-off-by: jtsang01 <[email protected]>
jimmytsang
force-pushed
the
refactor-request-pkg
branch
from
078f492 to
ac9aa7f
Compare
chandrasekhar1996
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace the
requestpackage withaxios