support product id (string) format association with domains #2193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we have a new productId field in domain meta that is defined as string value. the change does not introduce any backward incompatibility with existing solution (the old product numeric was stored in the db as ypm_id). To avoid confusion, the internal attribute names have been changed to indicate their use: productNumber and productId.
Also there are now 4 new config options that control whether or not the server should impose uniqueness checks on the domain attributes for product id, aws account, azure subscription and gcp project associations all with default value of true (current implementation):
athenz.zms.enforce_unique_aws_accounts=true
athenz.zms.enforce_unique_azure_subscriptions=true
athenz.zms.enforce_unique_gcp_projects=true
athenz.zms.enforce_unique_product_ids=true