New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for policy tags. #2210

Merged

abvaidya merged 2 commits into AthenZ:master from royelbaum:add_policy_tag_ui

Sep 11, 2023

Contributor

royelbaum commented Jun 20, 2023

Each policy version has its own tags.


          Add support for policy tags.

d0c5426

Each policy version has its own tags.

Signed-off-by: Roy Elbaum <[email protected]>
Signed-off-by: Roy Elbaum <[email protected]>

jimmytsang reviewed

View reviewed changes

ui/src/__tests__/redux/thunk/collection.test.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/__tests__/redux/thunk/collection.test.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/components/header/PolicyTabs.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/components/policy/PolicyRow.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/components/policy/PolicyRow.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/components/tag/TagList.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/redux/reducers/policies.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/server/handlers/api.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

ui/src/tests_utils/ComponentsTestUtils.js Show resolved Hide resolved

jimmytsang reviewed

View reviewed changes

Contributor

jimmytsang left a comment

Nice work Roy, left some comments 👍 . Hoping to see a simple functional tests to create/update policy tag then delete it afterwords.

jimmytsang approved these changes

View reviewed changes

Contributor

jimmytsang left a comment

👍

royelbaum force-pushed the add_policy_tag_ui branch from 3f5ab2d to 845aff6 Compare

August 27, 2023 14:41


          Fix comments

82b07d7

Signed-off-by: roy.elbaum <[email protected]>

royelbaum force-pushed the add_policy_tag_ui branch from 845aff6 to 82b07d7 Compare

August 28, 2023 09:04

chandrasekhar1996 approved these changes

View reviewed changes

abvaidya merged commit 1cbe6d2 into AthenZ:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet