Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for service tag #2237

Merged
merged 9 commits into from
Sep 12, 2023
Merged

Add support for service tag #2237

merged 9 commits into from
Sep 12, 2023

Conversation

royelbaum
Copy link
Contributor

@royelbaum royelbaum commented Jul 13, 2023 •
edited
Loading

Screenshot 2023-07-18 at 16 32 10
Screenshot 2023-07-18 at 16 33 12

Add support for service tag
a8960f6 
Signed-off-by: roy.elbaum <[email protected]>
@jimmytsang
Copy link
Contributor

changes look good so far, hoping to see a visual from screen recording 👍

Add support for service tag
8d12c9f 
Signed-off-by: roy.elbaum <[email protected]>
@royelbaum royelbaum force-pushed the add_service_tag_ui branch from 9505b4c to 8d12c9f Compare July 18, 2023 13:39
Fix comments
cb0c8a6 
Signed-off-by: roy.elbaum <[email protected]>
@royelbaum royelbaum force-pushed the add_service_tag_ui branch from 9ddc638 to cb0c8a6 Compare July 20, 2023 15:22
jimmytsang
jimmytsang approved these changes Jul 27, 2023
View reviewed changes
Copy link
Contributor

@jimmytsang jimmytsang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 nice work roy!

roy.elbaum and others added 5 commits August 27, 2023 17:29
Merge with master
f76466b 
Signed-off-by: roy.elbaum <[email protected]>
@abvaidya abvaidya merged commit 7198880 into AthenZ:master Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmytsang jimmytsang jimmytsang approved these changes

@chandrasekhar1996 chandrasekhar1996 chandrasekhar1996 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@royelbaum @jimmytsang @chandrasekhar1996 @abvaidya